This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Fix duplicate entity feature not using the modified value for position/rotation/scale #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 3dstreet-editor-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ng with the TransformControls, so that entity.flushToDOM() works correctly when duplicating an entity (fix 3DStreet#186)
vincentfretin
force-pushed
the
fix-duplicate-entity
branch
from
bd95cec
to
653fef6
Compare
|
In this same PR, I fixed the issue of model not loading when cloning entity like I described in |
|
thanks @vincentfretin this worked great and I appreciate all the writeups, very helpful to understand the underlying issues. |
|
closes #186 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same PR than aframe-inspector aframevr/aframe-inspector#695 but on your repo. This fixes #186
Properly call
setAttributefor position, rotation, scale when modifying with the TransformControls, so thatentity.flushToDOM()works correctly when duplicating an entity.This fixes aframevr/aframe-inspector#688
See my comment aframevr/aframe-inspector#688 (comment) for a more detailed explanation of the issue and the proposed fix.