This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
fix incorrect boundingBox #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 3dstreet-editor-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @Algorush. Which tram? If it is this model then you can ignore as we will be replacing: |
|
@Algorush Ok thanks well in that case yes we should support correct bounding box for that model. I just tested this and while I wasn't able to test animation, things work as expected (nothing is broken) for bounding box behavior so I'll merge |
|
@Algorush you may want my other change as well aframevr/aframe-inspector@ea6fb76 |
@vincentfretin Thank you very much for mention about this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vincent Fretin from Aframe advise to remove the old function
Box3.prototype.expandByObjectto correctly defineboundingBox:aframevr/aframe-inspector#686
I did this in the 3DStreet-editor repository in this PR and now the
boundingBoxis defined correctly for pedestrians and for almost all other objects... except the tram. I don't know why yet. It’s interesting that in a clean scene with two objects - a tram and a pedestrian, the boundingBox is determined correctly for both