This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vincent Fretin from Aframe advise to remove the old function
Box3.prototype.expandByObject
to correctly defineboundingBox
:aframevr/aframe-inspector#686
I did this in the 3DStreet-editor repository in this PR and now the
boundingBox
is defined correctly for pedestrians and for almost all other objects... except the tram. I don't know why yet. It’s interesting that in a clean scene with two objects - a tram and a pedestrian, the boundingBox is determined correctly for both