-
Notifications
You must be signed in to change notification settings - Fork 3
feat(ga): added save scene actions and new account creation #384
Conversation
✅ Deploy Preview for 3dstreet-editor-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Reviewing the code first, it looks like there is a bit more process around sign-in now so that we can do a query to see if a user is logging in for the first time therefore creating an account |
updated from master other questions:
how to test?
|
I started testing using the extension suggested above. It confirmed that we were sending events, but not to the development account as expected from the current environment file. Then I identified that we're still loading GA via index.html Instead we should instantiate google analytics via react / javascript so that we can use env credential. Please make these changes on this very PR so we can keep all the google analytics changes together |
…t/issue-324/ga-events
…et-editor into feat/issue-324/ga-events
hi @kfarr ! ive added ga via npm package react-ga4 and created new variable in envs "GA_ID". For development im using my GA_ID that i have created before. For production we need to use old GA_ID that stored in index.js at the end of the file. Also i changed all sending events from native js to sendMetrick() function. Here i ran into a problem that all my click events were not sent to ga servers in local development due to adblockers. So, If you want to test ga in local just remove all adblockers. |
looks great @rostyslavvnahornyi thanks for this and sorry for delayed review |
No description provided.