Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Match with 3dstreet index html #77

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Match with 3dstreet index html #77

merged 5 commits into from
Dec 2, 2022

Conversation

kfarr
Copy link
Contributor

@kfarr kfarr commented Nov 24, 2022

  • The 3dstreet-editor repo index.html should be as close as possible to index.html in 3dstreet repo, so that editor changes can be tested immediately against the same page as it will be used

- separate 3dtiles / cesium to separate example file
- add styles and buttons from viewer
- add logo from viewer (broken)

still to do
- test and lint
- see if viewer buttons still work
- change viewer logo
- remove viewer-styles.css and use github.3dstreet.org cdn?
remove unused functions, move ga to bottom
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
🔨 Latest commit 599082d
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/63814efd538dbe00099898c9
😎 Deploy Preview https://deploy-preview-77--3dstreet-editor-builds.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kfarr
Copy link
Contributor Author

kfarr commented Nov 24, 2022

still to do:

  • update viewer logo image to latest (both)
  • add support for loading buttons (editor)
  • prevent viewer logo collision (editor vs. viewer)
  • fix editor style collisions introduced by adding viewer-styles.css:
    --- selected item in layers panel is wrong color
    --- some editor buttons too tall
    --- too much empty space between global properties and component attributes in right-hand panel

remove content div
- add load from streetmix and json file
- add start editor logic from viewer
- set 2 second to autolaunch editor (this might be annoying)
@kfarr kfarr merged commit 9c3751b into master Dec 2, 2022
@kfarr kfarr deleted the match-3dstreet-index-html branch December 2, 2022 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant