This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Upgrade to react 18 and webpack 5 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update aframe-environment-component to 1.3.1 * replace THREE.Math by THREE.MathUtils * properly use BoxHelper, update method has no arguments anymore and setFromObject already call update so no need to call it a second time * rename geometries to remove warnings * fix rotate gizmo, setFromEuler needs a Euler instance
…hen using the inspector in a site that has tailwind base.css (#640)
* avoid error when attrValue is undefined (for example material component set via a mixin for shortOrange entity) * fix wrong number type for animation loop property * prevent copy to clipboard buttons to expand/collapse the panel * refresh SceneGraph after cloning entity * remove unused variables (this fixes the warning for SphereBufferGeometry in three r144) * call helper update() only if the helper has an update method
* remove unused imports * remove unused code * cleanup some eslint globals and eslint disable comment usage * remove empty ComponentHelp.js file * remove console.log * use substring instead of deprecated substr * fix unneeded regex escape * use import/export everywhere * fix eslint no-extra-semi * fix eslint comma-dangle * disable space-before-function-paren eslint rule that conflicts with prettier * declare className prop * fix some eslint errors * declare entity prop * add prettier config so it uses single quotes when saving via vscode, add src/lib/TransformControls.js to prettierignore to not reformat this file * remove unused variable * fix 'inspector' is defined but never used * remove unused trim function * disable react/no-danger on those files * remove unused onTouchStart onTouchEnd functions * specify trailingComma none that will be needed with latest version of prettier * fix some eslint errors found with latest eslint version
* Fix keydown/keyup listeners for shortcuts not properly removed when editor is reenabled * there is no need to call forceUpdate after calling setState * don't show + buttons when inspector is disabled * fix right panel + button to really be on the right * toggling a panel shouldn't impact the other one * add top 0 on left and right classes so the + button really shows up * replace spread syntax by Object.assign
On US international keyboards Ctrl + Alt are combined into AltGraph. When this happens Ctrl and Alt are registered as unpressed, breaking the toggle expression Co-authored-by: meteoorkip <svenkonings@live.nl>
* fix eslint errors with latest eslint version * update code to latest react api * update all dependencies, remove non used dependencies, properly separate devDependencies * fresh package-lock.json * revert to using the spread syntax * ignore new rules * React import not needed with new jsx runtime * inline the svg in the js bundle * define three as external to be able to import jsm file from three package * add three dependency * use GLTFExporter from three r145 * remove vendor/GLTFExporter.js * format files on pre-commit * update package-lock.json
* Fix checkbox that was always black when tailwindcss base style is present on the page * Fix alignement of span elements inside entityPrint * Fix initial value position in select fields * Remove 1px box-shadow applied by tailwindcss when input has focus
✅ Deploy Preview for 3dstreet-editor-builds ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vincentfretin
force-pushed
the
react18-webpack5
branch
from
a0b69ad
to
4367be0
Compare
|
Thanks @vincentfretin I've tested all of the key functionality and it all seems to work! @omedvediev can you review? minor style issue that we can resolve later:
|
This was referenced Dec 27, 2022
Merged
|
Hello @kfarr! @vincentfretin 's branch looks great. The App compiles without any error or warning and there are no runtime issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #40
Merge latest changes from aframe-inspector master, I ignored completely the changes in src/style folder.
How I did it:
Setting up upstream remote:
git clone git@github.com:3DStreet/3dstreet-editor.git cd 3dstreet-editor git remote add upstream git@github.com:aframevr/aframe-inspector.gitUpdate both remotes first if you already did the previous steps some time ago
Copy the repo in tmp directory to easily compare, and later retrieve the style folder unchanged
Create a new branch
Merge: