Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild team is changing "{major}.0" to "Current" #10

Closed
3F opened this issue Jan 10, 2019 · 2 comments · Fixed by #11
Closed

MSBuild team is changing "{major}.0" to "Current" #10

3F opened this issue Jan 10, 2019 · 2 comments · Fixed by #11

Comments

@3F
Copy link
Owner

3F commented Jan 10, 2019

MSBuild team is changing "{major}.0" to "Current" to make VS2019 and newer easier to automate in devops via vswhere.

microsoft/vswhere#162 (comment)

@gerhardol
Copy link
Contributor

Any thoughts about the permanent solution?
The following works so far, but from the vswhere discussion, a better should be done

image

@3F
Copy link
Owner Author

3F commented Apr 22, 2019

@gerhardol Here's src for this part, you can use PR: https://github.com/3F/hMSBuild/blob/master/frontend.bat#L522

About solution, what about future 17+ VS releases ? :)

I think GEQ operator is enough.

Also, I don't know more details about an "Current" naming, but just to be sure ( #3 (comment) ) probably we also need to check this dir like ~

if !vsver! GEQ 16 if exist "!thisDir!" (
	set vsver=Current
)

or maybe not ... well you can open PR, I will look into later.

Please also test the new solution in real usage. Thanks!
use build.bat for manual compile for your PC, or see CI appveyor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants