Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio 2017 Update 3 / MSBuild 15.3 #3

Closed
uli-weltersbach opened this issue Aug 16, 2017 · 3 comments
Closed

Visual Studio 2017 Update 3 / MSBuild 15.3 #3

uli-weltersbach opened this issue Aug 16, 2017 · 3 comments
Labels
bug support
Milestone
v1.2.2

Comments

@uli-weltersbach
Copy link
Contributor

uli-weltersbach commented Aug 16, 2017 •
edited
Loading

Microsoft decided to put v15.3 of MSBuild.exe in <VS2017 install dir>\MSBuild\15.0\Bin, not <VS2017 install dir>\MSBuild\15.3\Bin.

MSBuild.exe version

This means that the vsver variable is set incorrectly after updating to Visual Studio 2017 Update 3.
We've fixed it locally by changing line 323 of hMSBuild.bat (v1.2.1) from set vsver=%%a.%%b to set vsver=%%a.0.

Thanks for making your script available to the public, by the way :)
@3F
Copy link
Owner

3F commented Aug 16, 2017

thanks for the report

well, the main question what the directory name was planned by our MS for this at all -_-

because it extracted as {major}.{minor} version from installedVersion at this command -latest -requires Microsoft.Component.MSBuild

  • installationVersion: 15.0.26430.12 -> ... \MSBuild\15.0\Bin
  • installationVersion: 15.3.26730.3 -> yes, still ... \MSBuild\15.0\Bin

seems it probably can be like with .net framework and v4.0.30319 folder

Does anyone may clarify information about this ? Are you sure about {major}.0 ?

Thanks for making your script available to the public, by the way :)

I'm glad that it also helps for someone else ^_^

@uli-weltersbach uli-weltersbach mentioned this issue Aug 16, 2017
Merged
@3F 3F mentioned this issue Aug 16, 2017
Closed
@rainersigwald
Copy link

Does anyone may clarify information about this ? Are you sure about {major}.0 ?

The version in the directory structure is the ToolsVersion, not the Visual Studio version number. Historically, ToolsVersion has been fixed for a major version of Visual Studio. We don't have plans to change that at the moment, so {major.0} should work for the foreseeable future.

@3F
Copy link
Owner

3F commented Aug 16, 2017

@rainersigwald

I see, thanks for the detailed information !

@3F 3F closed this as completed in #6 Aug 16, 2017
@3F 3F added this to the v1.2.2 milestone Aug 16, 2017
3F added a commit that referenced this issue Aug 18, 2017
@3F
Public release of the hMSBuild v1.2.2
3ee58c3 
* FIXED: Updated GetNuTool v1.6.1:
         https://github.com/3F/GetNuTool/blob/master/changelog.txt

         Important fixes:
         * FIXED: Avoids errors with possible incorrect CRC & Compressed size info.
         * FIXED: Fixed problem "Input string was not in a correct format" when used version with release type.
         * FIXED: Fixed problems with paths and whitespace characters for `-unpack` command.

* FIXED: Visual Studio 2017 Update 3 compatibility. Issue #3.
* CHANGED: Non-zero exit code when compilation fails. Issue #4.
* NOTE: Now you can get the latest stable versions easily:
        * https://3F.github.io/hMSBuild/releases/latest/minified/
        * https://3F.github.io/hMSBuild/releases/latest/full/
        * https://3F.github.io/hMSBuild/releases/latest/light/
@3F 3F mentioned this issue Jan 9, 2019
Closed
@3F 3F mentioned this issue Apr 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug support
Projects
None yet
Milestone
v1.2.2
Development

No branches or pull requests
3 participants
@uli-weltersbach @3F @rainersigwald