Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-zero exit code when compilation fails #4

Closed
uli-weltersbach opened this issue Aug 16, 2017 · 1 comment
Closed

Non-zero exit code when compilation fails #4

uli-weltersbach opened this issue Aug 16, 2017 · 1 comment
Labels
support
Milestone
v1.2.2

Comments

@uli-weltersbach
Copy link
Contributor

I love your script, but I always end up modifying line 231 (v1.2.1) to return %ERRORLEVEL% instead of zero, so that hMSBuild.bat returns a non-zero exit code when MSBuild.exe fails.

Is there any reason why you decided to always return zero, even when MSBuild.exe encounters an error?
@3F 3F added the support label Aug 16, 2017
@3F
Copy link
Owner

3F commented Aug 16, 2017

Seems I left it from the initial draft. Yes the !ERRORLEVEL! is better option after call !xMSBuild! :)

I'll update this later, but you can also use pull-request, raw frontend is here:
https://github.com/3F/hMSBuild/blob/master/frontend.bat

btw, I've also plan to update GetNuTool core on this week if you're using it

@uli-weltersbach uli-weltersbach mentioned this issue Aug 16, 2017
Merged
@3F 3F closed this as completed in #5 Aug 16, 2017
@3F 3F added this to the v1.2.2 milestone Aug 16, 2017
3F added a commit that referenced this issue Aug 18, 2017
@3F
Public release of the hMSBuild v1.2.2
3ee58c3 
* FIXED: Updated GetNuTool v1.6.1:
         https://github.com/3F/GetNuTool/blob/master/changelog.txt

         Important fixes:
         * FIXED: Avoids errors with possible incorrect CRC & Compressed size info.
         * FIXED: Fixed problem "Input string was not in a correct format" when used version with release type.
         * FIXED: Fixed problems with paths and whitespace characters for `-unpack` command.

* FIXED: Visual Studio 2017 Update 3 compatibility. Issue #3.
* CHANGED: Non-zero exit code when compilation fails. Issue #4.
* NOTE: Now you can get the latest stable versions easily:
        * https://3F.github.io/hMSBuild/releases/latest/minified/
        * https://3F.github.io/hMSBuild/releases/latest/full/
        * https://3F.github.io/hMSBuild/releases/latest/light/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support
Projects
None yet
Milestone
v1.2.2
Development

No branches or pull requests
2 participants
@uli-weltersbach @3F