Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform native GUID creation #312

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Add platform native GUID creation #312

merged 6 commits into from
Feb 27, 2023

Conversation

martinweismann
Copy link
Member

@martinweismann martinweismann commented Feb 24, 2023

Addresses #271 :

  1. there is now a switch to compile lib3mf such that it uses the UUID generation provided by the host OS: USE_PLATFORM_UUID . It is OFF by default.
  2. std::random_device is not static anymore, only std::mt19937 and std::mutex are still static.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 71.65% // Head: 71.65% // No change to project coverage 👍

Coverage data is based on head (851784d) compared to base (1c5598b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #312   +/-   ##
========================================
  Coverage    71.65%   71.65%           
========================================
  Files          420      420           
  Lines        24213    24213           
========================================
  Hits         17349    17349           
  Misses        6864     6864           
Impacted Files Coverage Δ
Include/Common/NMR_UUID.h 100.00% <ø> (ø)
Source/Common/NMR_UUID.cpp 80.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martinweismann martinweismann changed the title Add crossguid (attribution missing) Add platform native GUID creation Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant