ISSUE-284: fix CSharp crash when passing struct #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
========================================
Coverage 59.08% 59.08%
========================================
Files 64 64
Lines 23589 23589
========================================
Hits 13937 13937
Misses 9652 9652 ☔ View full report in Codecov by Sentry. |
vijaiaeroastro
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Looks good @gangatp. Let's also introduce a few examples of this too for the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#284
When passing user-defined struct from CSharp bindings to C++, ref should be used to receive them as pointers in implementation side, if its not used it should be received as Value.
This is a direct patch, in the next release updating of ACT will resolve this issue.