Implemented memory pool for SYCL device/host memory #1039
Conversation
…and ZEX_* environment variables are not necessary. "ulimit -n" is not necessary.) Tuned SYCL kernel workgroup size (Showed big improvement in 2D classification performance) Fixed AccPtr host memory leak in PassWeights.weights (src/acc/acc_ml_optimiser_impl.h) Prevented threads of the same MPI rank from being assigned to different SYCL devices in automatic mapping Fix Intel IPP library header file for oneAPI 2024 release and older Minor update for SYCL2020 standard Consistent use of tab/space in source codes
|
Thank you very much for your continuing contributions! I am bit busy right now (MicroED and XFEL beam time) but hopefully will try to compile this by next Wednesday. (or can @scheres test this when you recompile the LMB binary?) By the way, please don't squash your commits when sending your PR next time so that I can see which change corresponds to which goal. |
|
@biochem-fan I have updated PR notes with a little bit more details. Sorry for the single commit which contains all the changes. This PR was made from Intel private branch, and it has lots of dirty and debug commits. So, I have made clean single git for this. I will make multiple commits in future PR which has lots of changes. |
|
I confirmed 6bba191 compiled and worked. Is this ready to be merged, or do you have more commits? |
|
@biochem-fan I have no more planned commits for this PR. |
|
OK, I merged this. Thanks! |
Implemented memory pool for SYCL device/host memory. (added src/acc/sycl/sycl_memory_pool.*)
Tuned SYCL kernel workgroup size.
Fixed AccPtr host memory leak in PassWeights.weights. (src/acc/acc_ml_optimiser_impl.h)
Prevented threads of the same MPI rank from being assigned to different SYCL devices in automatic mapping (ml_optimiser_mpi.cpp and ml_optimiser.cpp line 1740)
Fix Intel IPP library header file for oneAPI 2024 release and older. (CMakeLists.txt and src/acc/utilities.h)
Minor update for SYCL2020 standard.
Consistent use of tab/space in source codes under src/acc/sycl directory.