Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configs and improve the pipeline #25

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Remove configs and improve the pipeline #25

merged 7 commits into from
Oct 9, 2023

Conversation

zvan
Copy link
Contributor

@zvan zvan commented Sep 25, 2023

  • Kept angular config.
  • Took config from one of react TS projects that is currently in production.
  • Deleted rest of configs
  • Upgraded minimal @typescript-eslint to v6
  • added prettier to the project (removed unneeded rules from eslint that lints this project)
  • added lint and test phases for rules

Snapshots will fail if there is an update that alters any rules.
https://github.com/3fs/eslint-config/actions/runs/6297895370/job/17095741103

Matej Zvan added 6 commits September 25, 2023 10:11
- Delete all but angular
- Add react-typescript as it's used on Getinge project.
Run: npx eslint-config-prettier configs/react-ts.js and remove what's
reported from package eslint

remove; unnecessary might conflict:
- array-bracket-newline
- array-element-newline
- arrow-parens
- arrow-spacing
- block-spacing
- brace-style
- comma-dangle
- comma-spacing
- comma-style
- computed-property-spacing
- dot-location
- eol-last
- func-call-spacing
- function-paren-newline
- generator-star-spacing
- implicit-arrow-linebreak
- indent
- key-spacing
- keyword-spacing
- max-statements-per-line
- new-parens
- newline-per-chained-call
- no-extra-parens
- no-extra-semi
- no-floating-decimal
- no-mixed-spaces-and-tabs
- no-multi-spaces
- no-multiple-empty-lines
- no-trailing-spaces
- no-whitespace-before-property
- object-curly-newline
- object-curly-spacing
- object-property-newline
- operator-linebreak
- padded-blocks
- quote-props
- rest-spread-spacing
- semi
- semi-spacing
- semi-style
- space-before-blocks
- space-before-function-paren
- space-in-parens
- space-infix-ops
- space-unary-ops
- switch-colon-spacing
- template-curly-spacing
- template-tag-spacing
- wrap-iife
- yield-star-spacing

Removed; Enabled might conflict:
- curly
- no-tabs

Leave; can not check:
- max-len
- no-mixed-operators
- no-unexpected-multiline
- quotes
- fix issues in angular file
Copy link
Contributor

@nkrmavnar nkrmavnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

package.json Outdated Show resolved Hide resolved
@zvan zvan merged commit fdf5ed6 into master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants