Create upgrade_to_0.8.0.sql #100
Conversation
|
Merci pour la contribution @Jersig Pour faire du SQL, il y a 2 choses :
Il faut que les 2 soit synchro. Je viens de d'approuver le lancement des tests et avec surprise, le test est vert ... Je pense qu'il y a un soucis de notre côté suite à la migration Travis vers GitHub récemment. Parce que ton PR n'ayant que un fichier de migration, il y a donc une différence si quelqu'un fait l'installation d'une nouvelle base. Je dois vérifier ca. |
|
@Jersig Je me suis permis de faire un "rebase", CAD mettre à jour ton PR, suite à la découverte d'un problème possible ce matin. Donc comme dit ci-dessus, le test des migrations plante désormais car le PR ne couvre pas l'installation d'une base. Merci pour la puce à l'oreille :) |
pdrillin
force-pushed
the
patch-8
branch
2 times, most recently
from
db31bf9
to
5cc03eb
Compare
pdrillin
force-pushed
the
patch-8
branch
17 times, most recently
from
9a43214
to
e50980e
Compare
pdrillin
force-pushed
the
patch-8
branch
2 times, most recently
from
b5cfa0d
to
73752df
Compare
pdrillin
force-pushed
the
patch-8
branch
5 times, most recently
from
fba9605
to
8d6c4bb
Compare
| @@ -37,6 +37,7 @@ def tearDown(self) -> None: | |||
| del self.connection | |||
| time.sleep(1) | |||
|
|
|||
| @unittest.skip("Test desable because timeout") | |||
There was a problem hiding this comment.
| @unittest.skip("Test desable because timeout") | |
| @unittest.skip("Test disabled because of timeout") |
Can you elaborate the problem ? Does it work on on your local machine ? Is the problem only on GH Action ? (if yes, skip only on GH Action, not always, with environnement variable)
If you remove the latest migration, does it work ?
This test is IMHO important, so it would be good to now why there is a timeout and where in the code.
There was a problem hiding this comment.
On my local machine I ran it for about an hour and a half without it being finished
There was a problem hiding this comment.
More than 2 minutes, there is already something wrong, it's only a SQL script.
But is-it the latest migration making this trouble ?
There was a problem hiding this comment.
yes, is the migration 0.8.0
|
Ajouter |
Update of the latest production version of the "adresse" schema. It implements various objects type : • Functions • tables, sequences, default values • views • indexes • triggers • constrains • comments This upgrade aims to create new tables and setup several functions which automatically update different fields in our tables. It allow to produce assessment view used to export data with a structure expected by the project partners.
|
LGTM |
Update of the latest production version of the "adresse" schema.
It implements various objects type :
• Functions
• tables, sequences, default values
• views
• indexes
• triggers
• constrains
• comments
This upgrade aims to create new tables and setup several functions which automatically update different fields in our tables. It allow to produce assessment view used to export data with a structure expected by the project partners.