Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 muokka list template taulukko muotoon #89

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

ayriainen
Copy link
Collaborator

No description provided.

@ayriainen ayriainen linked an issue Dec 5, 2023 that may be closed by this pull request
@ayriainen
Copy link
Collaborator Author

Tämä on valmis mergettäväksi jo. Toimii sellaisenaan mainin kanssa, jos kohdan reference[1].format_bibtex() muuttaa muotoon reference[1].title. Tyylitiedosto styles.css on myös tärkeä tämän toimivuudelle.

@3nd3r1
Copy link
Owner

3nd3r1 commented Dec 6, 2023

Tämä myös hoitaa taskin #77, mutta täytyy odottaa, että format_bibtex metodit ovat valmiita.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4deda2c) 100.00% compared to head (cdde4d8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          141       141           
  Branches        11        11           
=========================================
  Hits           141       141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@3nd3r1 3nd3r1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyvä table. Robot-testit ovat kyllä refaktoroinnin tarpeessa, mutta hakkasin nyt toimivan ratkaisut.

Robot-testit aiheuttaa tällästä erroria:
[1206/112156.106:INFO:CONSOLE(454)] "Uncaught ReferenceError: submitted is not defined", source: http://localhost:5001/add (454)
Luulen, että tämä ongelma on kuitenkin routes/templateissa.

Lisäksi pistin ton kopiointi painikkeen piiloon, kun format_bibtex metodi ei ole vielä valmis.

Mergetään tämä kuitenkin nyt, kun toimii.

@toppahattu toppahattu merged commit 59a6afd into main Dec 6, 2023
3 checks passed
@toppahattu toppahattu deleted the 75-muokka-list-template-taulukko-muotoon branch December 6, 2023 09:49
Copy link
Collaborator

@toppahattu toppahattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tosi hyvältä näyttää!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muokka list-template taulukko muotoon
3 participants