Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/dynamic-watches #11

Merged
merged 6 commits into from
Jan 11, 2024
Merged

feat/dynamic-watches #11

merged 6 commits into from
Jan 11, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jan 11, 2024

Adds the ability to watch the controller owned resources automatically and dynamically once the controller is already started.
The idea is that the type tracker, that was already implemented and was being used for the resource pruner, now also sets up a new watch each time it sees a new resource type (GVK) being managed by the controller.

Pros:

  • Only watch for the APIs that the controller is actually using. Useful if the controller has optional dependencies on other APIs as avoids the requirement of always installing them in the cluster

Cons:

I have also added some missing documentation and fixed several misspells.

/kind feature
/kind documentation
/assign
/priority important-soon

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Jan 11, 2024
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jan 11, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de1539935ee9b9b11037e41ea8ce75d9715df26a

@roivaz
Copy link
Member Author

roivaz commented Jan 11, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@3scale-robot 3scale-robot merged commit b7ad2be into main Jan 11, 2024
4 checks passed
@3scale-robot 3scale-robot deleted the feat/dynamic-watches branch January 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants