Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to controller-runtime v0.17.2 #15

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Upgrade to controller-runtime v0.17.2 #15

merged 2 commits into from
Mar 21, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Mar 15, 2024 •
edited
Loading

Upgrades controller-runtime to v0.17.2.

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot requested review from raelga and slopezz March 15, 2024 17:12
@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Mar 15, 2024
@roivaz roivaz mentioned this pull request Mar 15, 2024
Open
@roivaz roivaz added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 21, 2024
@3scale-robot 3scale-robot removed the needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. label Mar 21, 2024
@roivaz roivaz added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Mar 21, 2024
@3scale-robot 3scale-robot removed the needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. label Mar 21, 2024
@roivaz roivaz self-assigned this Mar 21, 2024
@roivaz roivaz changed the title wip - Upgrade to controller-runtime v0.17.2 Upgrade to controller-runtime v0.17.2 Mar 21, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2dbb2352a7ce9239ac48c8b580977bfdb1fcd676

@roivaz roivaz force-pushed the feat/controller-runtime/v0.17.2 branch from 16ed4d8 to c5a7bca Compare March 21, 2024 15:37
@3scale-robot 3scale-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@3scale-robot 3scale-robot requested a review from raelga March 21, 2024 15:37
@roivaz roivaz force-pushed the feat/controller-runtime/v0.17.2 branch 3 times, most recently from ab59256 to 66f1bbc Compare March 21, 2024 15:40
@roivaz roivaz removed the needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. label Mar 21, 2024
@roivaz roivaz force-pushed the feat/controller-runtime/v0.17.2 branch from 66f1bbc to fa6a03d Compare March 21, 2024 15:41
@roivaz roivaz force-pushed the feat/controller-runtime/v0.17.2 branch from fa6a03d to 83cd80f Compare March 21, 2024 15:41
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6cba1e64b1ee0863fa81a3bc091d879c3697d2b7

@roivaz
Copy link
Member Author

roivaz commented Mar 21, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@3scale-robot 3scale-robot merged commit 8f9d3d5 into main Mar 21, 2024
4 checks passed
@3scale-robot 3scale-robot deleted the feat/controller-runtime/v0.17.2 branch March 21, 2024 15:50
@roivaz roivaz restored the feat/controller-runtime/v0.17.2 branch June 12, 2024 15:51
@roivaz roivaz deleted the feat/controller-runtime/v0.17.2 branch June 12, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @3scale-robot @raelga @slopezz