Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autossl possibility to configure s3 logging at AWS ELB #18

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented Jul 15, 2020

AutoSSL needs to have proxy-protocol enabled at AWS ELB, and having proxy protocol enabled make totally unnecessary to have s3 logging configured at AWS ELB.

@slopezz slopezz requested review from raelga and roivaz July 15, 2020 15:55
@slopezz slopezz self-assigned this Jul 15, 2020
Copy link
Member

@roivaz roivaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@slopezz slopezz merged commit 22885a5 into master Jul 15, 2020
@slopezz slopezz deleted the autossl-remove-s3-logging branch July 15, 2020 16:24
@raelga raelga added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/M Requires about a day to complete the PR or the issue. labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants