Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/template-annotations #238

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix/template-annotations #238

merged 2 commits into from
Dec 5, 2022

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Dec 5, 2022

Fixes the rollout triggers feature. The test for this was also wrong.

/kind bug
/priority critical-urgent
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 5, 2022
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Dec 5, 2022
@roivaz roivaz force-pushed the fix/template-annotations branch from 7fe65ce to dbbbc42 Compare December 5, 2022 11:35
@slopezz
Copy link
Member

slopezz commented Dec 5, 2022

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c219c5ad88e0bc2b7a77baeefda56f6ef0995a8c

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@roivaz roivaz removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@roivaz roivaz mentioned this pull request Dec 5, 2022
Merged
@roivaz
Copy link
Member Author

roivaz commented Dec 5, 2022

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@3scale-robot 3scale-robot merged commit ab29238 into main Dec 5, 2022
@3scale-robot 3scale-robot deleted the fix/template-annotations branch December 5, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @slopezz @3scale-robot