Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/System-config secret hash trigger #246

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented Jan 20, 2023

  • Adds the secret hash rollot trigger to system-config secret, which is defined on a CR field because it is managed externally to saas-operator, unlike the rest of the secrets that are managed as ExternalSecrets inside saas-operator
    • So right now, if there is a change on that external secret mounted on System saas-operator deployments/statefulsets (all except sphinx), a rollout will be automatically triggered so new created pods will load new secret values
  • Creates alpha release v0.18.0-alpha.10 that has been tested successfully in staging:
      annotations:
        saas.3scale.net/system-recaptcha.secret-hash: 6fd87786b8
        saas.3scale.net/system-backend.secret-hash: 7d69d9698b
        saas.3scale.net/system-master-apicast.secret-hash: 68c799f75b
        saas.3scale.net/system-events-hook.secret-hash: 6b99695c69
        saas.3scale.net/stg-saas-system-config.secret-hash: 7f9955868b  ## THIS
        saas.3scale.net/system-zync.secret-hash: 85c5cc6498
        saas.3scale.net/system-smtp.secret-hash: 54d765bf5c
        saas.3scale.net/system-multitenant-assets-s3.secret-hash: 7959c58cdd
        saas.3scale.net/system-app.secret-hash: 7b87786f7d
        saas.3scale.net/system-database.secret-hash: 7886f9678f

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jan 20, 2023
@3scale-robot 3scale-robot requested review from raelga and roivaz January 20, 2023 11:06
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ea58701bec89de58360efbfe05d0eec17999e5c

@slopezz
Copy link
Member Author

slopezz commented Jan 20, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@3scale-robot 3scale-robot merged commit 3b923ae into main Jan 20, 2023
@3scale-robot 3scale-robot deleted the fix/system-config-secret-trigger branch January 20, 2023 11:40
@slopezz slopezz mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants