Feat/Add sphinx/searchd batch size field #261
Merged
+97
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/feature
|
cc @mayorova |
roivaz
approved these changes
May 22, 2023
|
LGTM label has been added. Git tree hash: fb66e8b3879a348f6af453857369528118afa9ad
|
slopezz
force-pushed
the
feat/sphinx-batch-size
branch
from
10ee86a to
7425819
Compare
roivaz
approved these changes
May 22, 2023
|
LGTM label has been added. Git tree hash: 248f51d001b46d84631d4d1a4d94adbedc29030d
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/3scale/3scale-saas/pull/592#issuecomment-1540376532
Sphinx/searchd batch size is reduced in SaaS compared to default porta image config (from
1000to100).Right now in saas-operator we are configuring it only in sphinx statefulset (which will be deprecated soon in favour of searchd), however this makes no sense, since this value need to be on the sphinx clients (so system-app, system-console and system-sidekiq-X deployment/statefulsets).
/kind feature
/priority important-soon
/assign