Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Add decodingStrategy field to ExternalSecret with current default value #262

Merged
merged 3 commits into from
May 23, 2023

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented May 22, 2023

Since a few versions ago, ESO has added a new field called decodingStrategy whose default value is None.

https://external-secrets.io/v0.8.2/guides/decoding-strategy/

The External Secrets Operator has the feature to allow multiple decoding strategies during an object generation.

The decodingStrategy field allows the user to set the following Decoding Strategies based on their needs. decodingStrategy can be placed under spec.data.remoteRef, spec.dataFrom.extract or spec.dataFrom.find. It will configure the decoding strategy for that specific operation, leaving others with the default behavior if not set.

None (default)
ESO will not try to decode the secret value.

Base64
ESO will try to decode the secret value using [base64](https://datatracker.ietf.org/doc/html/rfc4648#section-4) method. If the decoding fails, an error is produced.

Base64URL
ESO will try to decode the secret value using [base64url](https://datatracker.ietf.org/doc/html/rfc4648#section-5) method. If the decoding fails, an error is produced.

Auto
ESO will try to decode using Base64/Base64URL strategies. If the decoding fails, ESO will apply decoding strategy None. No error is produced to the user.

This is causing constant differences in our reconcile logic for every deployed ExternalSecret, making saas-operator logs unsable. So this PR harcodes current default value on the ExternalSecret template (as other current fields that we are not interested into using another value).

It has been tested through an alpha release in staging, so a stable release v0.19.8 has been created.

/kind feature
/kind release
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/release Categorizes issue or PR as related to a new release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels May 22, 2023
@3scale-robot 3scale-robot requested review from raelga and roivaz May 22, 2023 15:47
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef06d6ac493473c6d7eb4c2d35b1da0422157cc7

@slopezz
Copy link
Member Author

slopezz commented May 23, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@3scale-robot 3scale-robot merged commit 6e4d62b into main May 23, 2023
@3scale-robot 3scale-robot deleted the feat/add-field-externalsecret branch May 23, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. kind/release Categorizes issue or PR as related to a new release. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants