Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful information to the Sentinel status #271

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 10, 2023

This PR adds the following information to the Sentinel status resource, so its more useful to monitor the status of the redis cluster:

  • Shows the slave priority config option
  • Shows some useful replication info

Example status:

❯ oc get sentinel stg-saas-sentinel -oyaml | yq -C ".status.monitoredShards[]"
name: shard01
servers:
  stg-saas-bck-storage01-04:
    address: 10.65.1.240:6379
    config:
      save: ""
      slave-priority: "100"
      slave-read-only: "yes"
    info:
      replication: 'master-link: up, sync-in-progress: no'
    role: slave
  stg-saas-bck-storage01-05:
    address: 10.65.6.181:6379
    config:
      save: ""
      slave-priority: "100"
      slave-read-only: "yes"
    info:
      replication: 'master-link: up, sync-in-progress: no'
    role: slave
  stg-saas-bck-storage01-06:
    address: 10.65.10.1:6379
    config:
      save: ""
      slave-priority: "100"
    role: master
name: shard02
servers:
  stg-saas-bck-storage02-01:
    address: 10.65.0.41:6379
    config:
      save: ""
      slave-priority: "100"
    role: master
  stg-saas-bck-storage02-02:
    address: 10.65.5.246:6379
    config:
      save: ""
      slave-priority: "100"
      slave-read-only: "yes"
    info:
      replication: 'master-link: up, sync-in-progress: no'
    role: slave
  stg-saas-bck-storage02-03:
    address: 10.65.10.167:6379
    config:
      save: ""
      slave-priority: "100"
      slave-read-only: "no"
    info:
      replication: 'master-link: up, sync-in-progress: no'
    role: slave

@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 10, 2023
@roivaz
Copy link
Member Author

roivaz commented Oct 10, 2023

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. and removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels Oct 10, 2023
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ba48f469b6bbd4e4d394f232375fc0a9f3eaa5d

@roivaz
Copy link
Member Author

roivaz commented Oct 11, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@3scale-robot 3scale-robot merged commit 049461b into main Oct 11, 2023
2 of 3 checks passed
@3scale-robot 3scale-robot deleted the improve-redis-instance-status branch October 11, 2023 09:28
@roivaz
Copy link
Member Author

roivaz commented Nov 3, 2023

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants