Fix/Sentinel switch-master-count metric #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/bug
3scale-robot
added
needs-size
roivaz
approved these changes
Nov 16, 2023
|
LGTM label has been added. Git tree hash: bca0e243bd944861c0694fb6242b87a4c09a0a23
|
|
/lgtm |
slopezz
force-pushed
the
fix/sentinel-switchMasterCount-metric
branch
from
fbf6443 to
2c2b0c1
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
roivaz
approved these changes
Nov 16, 2023
|
LGTM label has been added. Git tree hash: 36d19eb2ca8b9238ac00a9ea8a55a0c162539aac
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent migrations we saw that failover alert do not work on the first failover upon saas-operator pod creation.
The reason is, there is a timeseries database for every
redis_server, on latest migrations the failover orcurs on a new redis server instance, passing the counter fromnon-existto1, so prometheusratedoes not get it.In the next image, filtering per shard and sentinel, there are 3 timeseriesdb with
0value (the ones from old redis_servers), and one timeseriesdb with value1(new redis_server).This PR removes the
redis_serverlabel from switchMasterCount metric, the same already done at failoverAbortNoGoodSlaveCount, which is the same case, we want a metric per shard only./kind bug
/kind release
/priority important-soon
/assign