backend-storage/backups/tag-on-upload #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
the
kind/feature
3scale-robot
added
the
priority/important-longterm
3scale-robot
added
needs-size
slopezz
approved these changes
Nov 21, 2023
|
LGTM label has been added. Git tree hash: 2cdd2a7c669da8c469a793f356263f17ca47d73d
|
|
@roivaz can you please rebase? |
roivaz
force-pushed
the
backups/tag-on-upload
branch
from
10cfe34 to
742d6e5
Compare
slopezz
approved these changes
Nov 21, 2023
|
LGTM label has been added. Git tree hash: 3c0ca9c05c934a5b7edeb681084e943eaeda7788
|
|
/lgtm |
raelga
approved these changes
Nov 21, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the bucket replication policy based on tags to trigger in a replicated AWS bucket, the tags need to be present on object creation. Uploading the object and then adding the backups doesn't trigger the replication.
This PR uses python's boto3 to upload the backup intead of awscli, as it has support to specify object tags directly in the upload api call.
The code has been reworked to support both the remote execution over ssh of commands and scripts passed through stdin to the remote server.
/kind feature
/priority important-longterm
/assign