basereconciler v0.4 #282
Merged
basereconciler v0.4 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
do-not-merge/work-in-progress
kind/feature
3scale-robot
added
needs-size
roivaz
force-pushed
the
basereconciler-v0.4
branch
2 times, most recently
from
874b875 to
aee5061
Compare
roivaz
force-pushed
the
basereconciler-v0.4
branch
from
18b8930 to
eb6ecd8
Compare
3scale-robot
added
size/XXL
roivaz
force-pushed
the
basereconciler-v0.4
branch
11 times, most recently
from
5419404 to
2e8886c
Compare
|
/retitle basereconciler v0.4 |
… unexported fields
Basereconciler is now more capable so the things that the workload reconciler did can now be done using just the basereconciler. Workload is now just a package with functions to generate templates.
roivaz
force-pushed
the
basereconciler-v0.4
branch
from
2e8886c to
5871eb5
Compare
slopezz
approved these changes
Jan 8, 2024
|
LGTM label has been added. Git tree hash: 90ec0739c18732f36893c5249df42101940d5848
|
slopezz
approved these changes
Jan 8, 2024
|
LGTM label has been added. Git tree hash: ed9afb25986aba4f6450233df5b3c87263f94865
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to basereconciler v0.4
/kind feature
/priority important-longterm
/assign