Feat/Add tls_maximum_protocol_version TLSv1.3 to EnvoyConfig #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
the
kind/feature
3scale-robot
added
the
priority/important-soon
3scale-robot
added
needs-size
roivaz
approved these changes
Jan 23, 2024
|
LGTM label has been added. Git tree hash: 55894e074a395182b45031cfadf1e20ff1387c36
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/3scale/3scale-saas/issues/738
At #288 it was added compatibility with envoy 1.22
Now we have seen that Red Hat productized envoy image, if not specified the tls_maximum_protocol_version, by default it uses
TLSv1.2, unlike upstreamenvoyproxy/envoywhich usesTLSv1.3by default.However, if specified the tls_maximum_protocol_version, Red Hat productized envoy image will use any specified version.
So this PR harcodes tls_maximum_protocol_version to
TLSv1_3, so it does not matter if we use upstream or productized envoy image, the used TLS protocols will be the same./kind feature
/priority important-soon
/assign