-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Update zync controller #9
Conversation
…n always desired enabled log format
Original motivation of the init container was to prevent the pod from crashing at startup time. When deploying 3scale, customers temporarily saw pods crashing (due to DB not available because it's booting up, and zync process crashing when it's not available) and being restarted until DB connectivity was available, which was perceived as "unstability" of the deployment from their given feedback (pods in 'red', crashing and restarting until their dependencies were available, etc.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, lgtm!
Solves part of https://github.com/3scale/platform/issues/235
dbWaitSleepSeconds
(was only used on removed init container)railsEnv
var (test/development/production), leave default value todevelopment
), otherwise when pod starts it complains about:railsLogsToStdout
: 3scale product already enables it by default and cannot be tuned, it seems it just changes the logger format, and there is no reason to not have it always enabled. In addition, it is only used on production environment (RAILS_ENV=production), which is the only environment value possible for serious zync deployments (staging/production...), because it enables all zync features. Actually, although it is used as a boolean, zync app just checks if var is present, independently from the value.