Prepare usage of registry.redhat.io registry #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
changed the title
miguelsorianod
force-pushed
the
use-redhat-io-registry
branch
from
4e1a6be to
676f37b
Compare
miguelsorianod
force-pushed
the
migrate-dbs-to-imagestreams
branch
2 times, most recently
from
5fb1bbb to
d043201
Compare
miguelsorianod
force-pushed
the
use-redhat-io-registry
branch
from
676f37b to
5606a8f
Compare
miguelsorianod
force-pushed
the
migrate-dbs-to-imagestreams
branch
from
d043201 to
124d66e
Compare
miguelsorianod
force-pushed
the
use-redhat-io-registry
branch
from
8c39747 to
69c6c2f
Compare
miguelsorianod
changed the base branch from
migrate-dbs-to-imagestreams
to
master
miguelsorianod
changed the title
miguelsorianod
changed the title
eguzki
reviewed
May 24, 2019
| @@ -575,7 +575,7 @@ func (ampImages *AmpImages) buildQuayServiceAccount() *v1.ServiceAccount { | |||
| }, | |||
| ImagePullSecrets: []v1.LocalObjectReference{ | |||
| v1.LocalObjectReference{ | |||
| Name: "quay-auth"}}} | |||
| Name: "threescale-registry-auth"}}} | |||
There was a problem hiding this comment.
function still called buildQuayServiceAccount, kind of weird. isn't it?
eguzki
approved these changes
May 24, 2019
miguelsorianod
force-pushed
the
use-redhat-io-registry
branch
from
69c6c2f to
4220a0a
Compare
eguzki
approved these changes
May 24, 2019
miguelsorianod
force-pushed
the
use-redhat-io-registry
branch
from
4220a0a to
7388dd9
Compare
miguelsorianod
force-pushed
the
use-redhat-io-registry
branch
from
7388dd9 to
25ca587
Compare
|
Code Climate has analyzed commit 25ca587 and detected 0 issues on this pull request. View more on Code Climate. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to prepare for the use of registry.redhat.io in the images for 2.6 releases and newer ones.
The old RedHat registry access.redhat.com will be deprecated and newer images are not going to be published on it. New images are going to be published in registry.redhat.io. This registry requires authentication.
This PR allows configuring the authentication credentials for the registry.redhat.io via a secret called 'threescale-registry-auth'. This secret is associated to the "amp" ServiceAccount that has been assigned to all the DeploymentConfig elements of the platform.
The final user is the only one that knows the credentials it has so the secret must be created by them with the specific fields needed and values needed before deploying the APIManager/the templates. Otherwise, the deploy will fail.
We can think of making the secret name configurable, but for the moment to already have something we can merge it this way.
In case of making it configurable I would:
In the templates we could:
In the operator we could: