Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator sdk v0.8.0 #126

Merged
merged 6 commits into from
May 24, 2019
Merged

Operator sdk v0.8.0 #126

merged 6 commits into from
May 24, 2019

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented May 21, 2019 •
edited
Loading

  • operator sdk v0.8.0
  • Dependency management with Go modules. Dropping dep and Gopkg.toml dependency management system
  • breaking change: BindingSpec APISelector attribute, now apiSelector
  • Upgrading Go runtime to 1.12.5

@eguzki eguzki changed the title [WIPOperator sdk v0.8.0 [WIP] Operator sdk v0.8.0 May 21, 2019
@eguzki eguzki requested a review from miguelsorianod May 21, 2019 10:35
@eguzki eguzki added the work in progress Don't merge, there's still work to do. label May 21, 2019
eguzki
eguzki commented May 21, 2019
View reviewed changes
pkg/apis/apps/v1alpha1/apimanager_types.go
// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster
// Important: Run "operator-sdk generate k8s" to regenerate code after modifying this file
Conditions []APIManagerCondition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,4,rep,name=conditions"`
Conditions []APIManagerCondition `json:"conditions,omitempty" protobuf:"bytes,4,rep,name=conditions"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patchStrategy and pathMerge tags removed. operator-sdk generate openapi failed

Still unknown why

@eguzki eguzki force-pushed the operator-sdk-v0.8.0 branch 2 times, most recently from ad27ba8 to 45b794b Compare May 22, 2019 14:02
@eguzki eguzki removed the work in progress Don't merge, there's still work to do. label May 22, 2019
@eguzki eguzki changed the title [WIP] Operator sdk v0.8.0 Operator sdk v0.8.0 May 22, 2019
@eguzki
Copy link
Member Author

eguzki commented May 22, 2019

ready for review @miguelsorianod

miguelsorianod
miguelsorianod suggested changes May 22, 2019
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the README.md on instructions on how to install and build it with the new dependency method and cleanup 'dep' references too

@eguzki eguzki force-pushed the operator-sdk-v0.8.0 branch from 3d5136a to 4fbbcaf Compare May 24, 2019 14:29
@codeclimate
Copy link

codeclimate bot commented May 24, 2019

Code Climate has analyzed commit 4fbbcaf and detected 62 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 58

View more on Code Climate.

@miguelsorianod miguelsorianod self-requested a review May 24, 2019 16:07
@miguelsorianod miguelsorianod merged commit aacbf4a into master May 24, 2019
@eguzki eguzki deleted the operator-sdk-v0.8.0 branch May 24, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @miguelsorianod