Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific CR field reconciliation pattern implementation approach #204

Merged
merged 26 commits into from
Sep 6, 2019
Merged

Specific CR field reconciliation pattern implementation approach #204

merged 26 commits into from
Sep 6, 2019

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Aug 12, 2019 •
edited
Loading

New reconciliation approach based on k8s native object fields controlled directly by CR fields.

  • Backend reconciliation
  • ampimages reconciliation
  • AMP Service account reconciliation
  • apicast reconciliation
  • Redis backend reconciliation
  • Redis system reconciliation
  • Postgresql system reconciliation
  • MySql system reconciliation
  • Memcached reconciliation
  • Zync reconciliation
  • System reconciliation

@eguzki eguzki added the work in progress Don't merge, there's still work to do. label Aug 12, 2019
@eguzki eguzki requested a review from miguelsorianod August 12, 2019 17:17
@codeclimate
Copy link

codeclimate bot commented Aug 12, 2019

Code Climate has analyzed commit a4434c0 and detected 316 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 44
Duplication 68
Style 204

View more on Code Climate.

@eguzki eguzki changed the base branch from master to operator-apimanager-reconcile August 12, 2019 17:18
@eguzki eguzki force-pushed the new-reconcile-approach branch 4 times, most recently from cbec8c8 to 7d473b8 Compare August 23, 2019 10:19
@eguzki eguzki changed the title [WIP] New reconcile approach [WIP] Specific CR field reconciliation pattern implementation approach Aug 23, 2019
@eguzki eguzki force-pushed the new-reconcile-approach branch 14 times, most recently from d061d9d to 6f9d246 Compare August 29, 2019 15:57
@eguzki eguzki removed the work in progress Don't merge, there's still work to do. label Aug 29, 2019
@eguzki eguzki changed the title [WIP] Specific CR field reconciliation pattern implementation approach Specific CR field reconciliation pattern implementation approach Aug 29, 2019
@eguzki
Copy link
Member Author

eguzki commented Aug 29, 2019

@miguelsorianod ready for review

@miguelsorianod
Copy link
Contributor

miguelsorianod commented Sep 3, 2019 •
edited
Loading

I think we should reconcile the APIManager OwnerReference object in case it is not set, for all objects that are managed by the APIManager.
For example, if the user precreates a configmap/secret because he wants to set some values different than the default ones the operator should add an owner reference to it.

eguzki added 22 commits September 5, 2019 17:19
@eguzki
configmap reconciler
e665514
@eguzki
secret reconciler
cad11d6
@eguzki
imagestream reconciler
feded55
@eguzki
service account reconciler
c934300
@eguzki
role binding reconciler
e906b0a
@eguzki
role reconciler
f90d6cb
@eguzki
persistent volume claim reconciler
48da9d6
@eguzki
service reconciler
1beb66e
@eguzki
route reconciler
8dddd99
@eguzki
backend reconciliation logic
568aecc
@eguzki
ampimages imagestreams reconciliation logic
f777a13
@eguzki
apicast reconciliation logic
223cc4f
@eguzki
redis backend reconciliation logic
bb7a9f8
@eguzki
system postgresql reconciliation logic
75e99fb
@eguzki
system mysql reconciliation logic
a8d9156
@eguzki
memcached reconciliation logic
7369467
@eguzki
zync reconciliation logic
59a7eda
@eguzki
system reconciliation logic
99518d4
@eguzki
reconciliation code cleanup
a9994cf
@eguzki
fix setting redis resource limits
2452798
@eguzki
go.mod: upgraded to v0.3.0
404bea9
@eguzki
apimanager_controller cleanup unused code
d0ada2c
@eguzki eguzki force-pushed the new-reconcile-approach branch from 235619b to 057004e Compare September 5, 2019 15:19
@eguzki
Copy link
Member Author

eguzki commented Sep 5, 2019

  • Labels and Annotations reconciled for all resource types
  • Created DefaultsOnlySecretReconciler: Only reconciles when field is missing.
  • Ownerrefrence set for pre-created secrets and configmaps

Ready for review @miguelsorianod

@eguzki eguzki force-pushed the new-reconcile-approach branch from 057004e to 9f0fcf8 Compare September 5, 2019 15:30
@miguelsorianod
Copy link
Contributor

Looks good 👍

@eguzki eguzki merged commit 8049224 into operator-apimanager-reconcile Sep 6, 2019
@eguzki eguzki deleted the new-reconcile-approach branch September 6, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @miguelsorianod