metrics endpoint include 3scale operator and product version #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what I've read using the global registry is not very recommendable and they recommend creating your own registry over that because the global registry is global state and for some other reasons: At the same time operator-sdk though it seemed/seems the operator-sdk used/uses the global registry too so I think what we have now works good enough 👍 . However if you want to take time to look into that up to you. |
miguelsorianod
approved these changes
Dec 12, 2019
eguzki
force-pushed
the
metrics-endpoint-3scale-info
branch
from
82972ab to
e177417
Compare
eguzki
force-pushed
the
metrics-endpoint-3scale-info
branch
from
e177417 to
6d7a866
Compare
|
Code Climate has analyzed commit 6d7a866 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the metrics endpoint in the operator to include operator version and 3scale product version: