-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metering Labels #367
Metering Labels #367
Conversation
Implemented first for apicast deployment. @miguelsorianod Let's verify implementation before going for other deployments. |
8253fad
to
d284a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me 👍 . Left some feedback regarding naming / potential deduplication
resolved duplication issues. |
Looks good, it can be applied to others 👍 |
adfaffb
to
79b2884
Compare
ready for review @miguelsorianod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed. I left some feedback
Applied changes look good to me 👍 I noticed another change and I left feedback on it. |
Code Climate has analyzed commit 5c9ebb4 and detected 65 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
All changes applied and feedback answered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Metering labels
https://docs.google.com/document/d/1bd9VnZ9jKwDBOOKAJltAtvhz3COUYYmRe3-BGE6fDGE/edit?ts=5de56bf6