backup/restore functionality - PVC subset #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
force-pushed
the
backup-restore-integration
branch
from
0da39b1 to
915673c
Compare
eguzki
requested changes
Jun 19, 2020
pkg/controller/apimanagerrestore/apimanagerrestore_logic_reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controller/apimanagerrestore/apimanagerrestore_logic_reconciler.go
Outdated
Show resolved
Hide resolved
miguelsorianod
force-pushed
the
backup-restore-integration
branch
from
915673c to
2757151
Compare
|
Applied changes and answered comments |
|
comments left |
|
Changes applied |
- Add APIManagerBackup type - Add APIManagerRestore type - Implement APIManagerBackup controller and model logic with PVC as destination and PVC as System's FileStorage - Implement APIManagerRestore controller and model logic with PVC as source and PVC as System's FileStorage - Add operator APIManager-based 3scale backup and restore documentation
…etCleanup The job is now automatically deleted when deleting the CR (via ownerReference)
With a default or from an environment variable
Several restore steps always expected the shared secret to always be available. However, one of the last steps is removing them. That made steps fail in some situations where reconciliation loop was reexecuted again. This commit adds a new Status field 'APIManagerToRestoreRef' that contains the name of the APIManager to restore, and the steps that needed the secret now can do their tasks using this flag.
Implement path omission mechanism in CRD tests to exclude specific fields When used fields in the CRDs have unexported fields or are serialized in a different format than the defined Golang object the schema.MissingEntries method reports them as missing. Implemented a mechanism to be able to ignore specific entries and added the ones where we were having this situation.
miguelsorianod
force-pushed
the
backup-restore-integration
branch
2 times, most recently
from
2a2738d to
c9ca8a8
Compare
|
LGTM Fix failing tests and let's merge |
miguelsorianod
force-pushed
the
backup-restore-integration
branch
from
25ef4e5 to
5f68780
Compare
|
Code Climate has analyzed commit 5f68780 and detected 124 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Fixed failing tests: added back the wildcard permission on apps.3scale.net, the removal of it was causing errors creating some objects https://app.circleci.com/pipelines/github/3scale/3scale-operator/2061/workflows/749dbf90-69c4-40d6-821b-2c8d87a2fc2f/jobs/13598 |
eguzki
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge backup/restore PVC subset new functionality integration branch into master