operator deployment resource requests #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
force-pushed
the
operator-resource-requests
branch
from
f1c25c8 to
33ff021
Compare
|
What was the conclusion about limits? I didn't send this PR as a decision on that didn't seem taken seeing the comments where it is being discussed now and the feedback we got |
|
There is no hard opinion about limits. The little benefit of making the operator restart when there are memory leaks is not seen in other operators. We can always add limits later if there is a good reason to do so. |
miguelsorianod
approved these changes
Sep 3, 2020
miguelsorianod
force-pushed
the
operator-resource-requests
branch
from
33ff021 to
4dbee27
Compare
|
Code Climate has analyzed commit 4dbee27 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.redhat.com/browse/THREESCALE-5860
What
Currently, no requests or limits for CPU and memory are set for the 3scale operator.
Current QoS class
Best Effort
How
Requests and limits for CPU and memory should be set in the operator deployment which will be used for the CSV generation.