Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charts for the Apisonator Internal API #473

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Sep 23, 2020

This PR adds charts for the Apisonator Internal API.

I know I have to run make assets but it's giving me an error because it can't download one of the dependencies. Not sure if it's a temporary issue.

@eguzki
Copy link
Member

eguzki commented Sep 23, 2020

I wish it was a temporary issue. One of the indirect dependencies is gone. bitbucket.org/ww/goautoneg

We are working on this issue and once we merge to master, you will need to rebase to pass all the checks

@eguzki
Copy link
Member

eguzki commented Sep 23, 2020

PR sent to fix the missing dep: #475

@eguzki
Copy link
Member

eguzki commented Sep 25, 2020

rebase and run make assets to embed the changes of the templates in the compiled binary.

@eguzki eguzki self-requested a review September 25, 2020 13:27
@davidor davidor force-pushed the apisonator-internal-api-metrics branch from badbaeb to 06d5505 Compare September 28, 2020 07:37
@davidor
Copy link
Contributor Author

davidor commented Sep 28, 2020

I've rebased and run make assets.

@eguzki
Copy link
Member

eguzki commented Sep 28, 2020

Dashboard of 10k lines

#GodSaveUs

@miguelsorianod miguelsorianod force-pushed the apisonator-internal-api-metrics branch from 06d5505 to fbff49c Compare September 29, 2020 09:19
@codeclimate
Copy link

codeclimate bot commented Sep 29, 2020

Code Climate has analyzed commit fbff49c and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants