Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconcile system database secret when external databases enabled #486

Merged
merged 7 commits into from
Oct 7, 2020
Merged

reconcile system database secret when external databases enabled #486

merged 7 commits into from
Oct 7, 2020

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Oct 2, 2020 •
edited
Loading

When external databases are enabled, system database secret is not reconciled, hence ower reference is not set.

The implementation required some refactoring:

  • Backend redis secret is reconciled in redis_reconciled.go and highavailability_reconciler.go. It has been removed from backend_reconciled.go
  • System redis secret is reconciled in redis_reconciled.go and highavailability_reconciler.go. It has been removed from system_reconciled.go
  • highavailabiilty_reconciler.go now reconciles three secrets: system redis, backend redis and system database secrets..

TODO

  • new HA reconciler unittests
  • redis option provider unittests update with new redis params

@eguzki eguzki requested a review from miguelsorianod October 2, 2020 19:21
@eguzki eguzki force-pushed the fix-system-database-secret-ownership branch 2 times, most recently from 5591561 to aca747c Compare October 2, 2020 20:49
miguelsorianod
miguelsorianod suggested changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks good to me 👍

I left some comments

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Oct 6, 2020
@eguzki eguzki force-pushed the fix-system-database-secret-ownership branch from 6fc0e77 to e1cb73e Compare October 6, 2020 13:40
@eguzki eguzki assigned eguzki and unassigned miguelsorianod Oct 6, 2020
@eguzki eguzki marked this pull request as ready for review October 6, 2020 16:20
@eguzki eguzki assigned miguelsorianod and unassigned eguzki Oct 6, 2020
@codeclimate
Copy link

codeclimate bot commented Oct 6, 2020

Code Climate has analyzed commit 4a11bf8 and detected 41 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 11
Style 26

View more on Code Climate.

@miguelsorianod miguelsorianod merged commit 06010c3 into master Oct 7, 2020
@miguelsorianod miguelsorianod deleted the fix-system-database-secret-ownership branch October 7, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees

@miguelsorianod miguelsorianod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @miguelsorianod