Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeveloperAccount and DeveloperUser CRDs #551

Merged
merged 17 commits into from
Feb 19, 2021
Merged

DeveloperAccount and DeveloperUser CRDs #551

merged 17 commits into from
Feb 19, 2021

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Dec 16, 2020 •
edited
Loading

CRD (and controller) for managing 3scale developer accounts.
CRD (and controller) for managing 3scale developer user accounts.

Requires 3scale/3scale-porta-go-client#40

  • CR samples
  • Usage doc / reference doc
  • CRD diagram update
  • User Suspend/Unsuspend
  • User Password from secret
  • validation of user email

@eguzki eguzki changed the title account CRD Account CRD Dec 16, 2020
@eguzki eguzki changed the title Account CRD Account and User CRD Jan 21, 2021
@eguzki eguzki changed the title Account and User CRD Account and AccountUser CRD Jan 21, 2021
@eguzki eguzki changed the title Account and AccountUser CRD DeveloperAccount and DeveloperUser CRDs Jan 25, 2021
@eguzki eguzki force-pushed the account-crd branch 4 times, most recently from df979c2 to ac6b215 Compare February 1, 2021 15:13
@eguzki
Copy link
Member Author

eguzki commented Feb 2, 2021

@miguelsorianod ready for initial review. Only doc is missing.

miguelsorianod
miguelsorianod reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good 👍

I left some comments

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Feb 3, 2021
@eguzki
Copy link
Member Author

eguzki commented Feb 3, 2021

👍 I am going to write the doc

@eguzki eguzki marked this pull request as ready for review February 18, 2021 01:25
@eguzki eguzki assigned miguelsorianod and unassigned eguzki Feb 18, 2021
miguelsorianod
miguelsorianod suggested changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks good to me 👍 .

There's one pending change regarding APIversion of some files

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Feb 18, 2021
@codeclimate
Copy link

codeclimate bot commented Feb 18, 2021

Code Climate has analyzed commit 6c29dca and detected 65 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 16
Duplication 19
Style 30

View more on Code Climate.

@eguzki eguzki merged commit fcd11d0 into master Feb 19, 2021
@eguzki eguzki deleted the account-crd branch February 19, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees

@miguelsorianod miguelsorianod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eguzki @miguelsorianod @openshift-ci-robot