Enable builds/ testing on ppc64le architecture #613
Conversation
This PR will allow to build container image and allow e2e testing on ppc64le architecture Signed-off-by: Krishna Harsha Voora <krishvoor@in.ibm.com>
|
Hi @krishvoor. Thanks for your PR. I'm waiting for a 3scale member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -18,7 +18,8 @@ COPY pkg/ pkg/ | |||
| COPY version/ version/ | |||
|
|
|||
| # Build | |||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o manager main.go | |||
There was a problem hiding this comment.
Why not
RUN CGO_ENABLED=0 GOOS=linux GOARCH=`go env GOARCH` GO111MODULE=on go build -a -o manager main.go
There was a problem hiding this comment.
Makes sense, will update.
| @@ -66,7 +66,7 @@ TEST_E2E_PKGS = $(shell $(GO) list ./... | grep 'github.com/3scale/3scale-operat | |||
| ENVTEST_ASSETS_DIR=$(PROJECT_PATH)/testbin | |||
| test-e2e: generate fmt vet manifests | |||
| mkdir -p ${ENVTEST_ASSETS_DIR} | |||
| test -f $(ENVTEST_ASSETS_DIR)/setup-envtest.sh || curl -sSLo $(ENVTEST_ASSETS_DIR)/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.6.3/hack/setup-envtest.sh | |||
There was a problem hiding this comment.
controller-runtime v0.6.3 is being used when compiling the operator.
Why should we change the version?
There was a problem hiding this comment.
controller-runtime v0.6.3 does not contain ppc64le compatible kubebuilder-tools.
Bumping up the controller-runtime v0.8.0 will allow test-e2e to be executed on ppc64le as well.
This PR will allow to build container image and allow e2e testing on ppc64le architecture Signed-off-by: Krishna Harsha Voora <krishvoor@in.ibm.com>
|
Code Climate has analyzed commit 939de00 and detected 0 issues on this pull request. View more on Code Climate. |
|
/ok-to-test |
This PR will allow to build container image
and allow e2e testing on ppc64le architecture
Signed-off-by: Krishna Harsha Voora krishvoor@in.ibm.com