-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system-mysql internal DB from MySQL 5.7 to 8.0 #682
Conversation
At the moment this cannot be merged due to system's pre-hook pod is failing to start after this changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a very easy one :)
starting command line or env vars... all remain the same from 5.7 to 8? Seems like 5.8 more than 8.0 :) |
It should remain the same. It's 8.0. MySQL 5.8 does not exist. |
17fdb55
to
7eb12c0
Compare
da25c68
to
51aafe6
Compare
The change of image also implies an automated upgrade from MySQL 5.7 to 8.0 when coming from an older 3scale installation where 5.7 is used. There is no need for a custom upgrade procedure.
51aafe6
to
07405ef
Compare
An error occurred when fetching issues. View more on Code Climate. |
@MStokluska added verification steps |
Reviewed code and tested in an upgrade scenario on my cluster. Looks good to me. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, verified changes on cluster and code looks good as well
The change of image also implies an automated upgrade from
MySQL 5.7 to 8.0 when coming from an older 3scale installation
where 5.7 is used. There is no need for a custom upgrade procedure.
The data migration is performed automatically when changing the image.
On the product side, the image to be set will be:
registry.redhat.io/rhscl/mysql-80-rhel7:8.0
JIRA: https://issues.redhat.com/browse/THREESCALE-7786
which depends on https://issues.redhat.com/browse/THREESCALE-6825
Verification steps
Deploy 3scale with the APIManager
Wait for the deployment to be ready
Check mysql 8 is running