fix cascading deletion #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MStokluska
force-pushed
the
fix-cascading-deletion
branch
from
bc23726 to
323db95
Compare
|
Code Climate has analyzed commit 323db95 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
I was looking going to implement something very similar. Then I realized that in the backend controller, if the secret is not found, then the product CR references to that backend are not deleted. I refactored a bit to decouple backend deletion from 3scale and product reference cleaning. Let me know what you think: #747 |
|
closing in favor of #747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cascading deletion issue when provider account secret is not found
Verification:
Create tenant
Create backend associated with that tenant
Create product associated with that tenant
Remove tenant
Confirm product and backend CRs are deleted as well