Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREESCALE-8749: Ability to set APICAST_SERVICE_CACHE_SIZE #793

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

sergioifg94
Copy link
Contributor

@sergioifg94 sergioifg94 commented Nov 10, 2022

Description

Add optional fields in the Apicast production and staging sections of the APIManager CRD that sets the APICAST_SERVICE_CACHE_SIZE environment variable in the Apicast containers

Verification steps

On a cluster, run the operator and create an APIManager with the new fields set. Check that once reconciled the DeploymentConfigs include the environment variable with the value from the new fields:

  1. Apply the manifests
    make install
  2. Run the operator
    make run
  3. Create an APIManager that includes the following in the spec:
    apicast:
      productionSpec:
        serviceCacheSize: 20
      stagingSpec:
        serviceCacheSize: 10
  4. Check the DeploymentConfigs for APICast
    oc get dc/apicast-staging -o yaml
    oc get dc/apicast-production -o yaml
  5. Verify that they include the environment variable
    # apicast-staging
    - name: APICAST_SERVICE_CACHE_SIZE
       value: '10'
    
    # apicast-production
    - name: APICAST_SERVICE_CACHE_SIZE
       value: '20'

Add optional fields in the Apicast production and staging sections of
the APIManager CRD that set the `APICAST_SERVICE_CACHE_SIZE` environment
variable in the Apicast containers
@codeclimate
Copy link

codeclimate bot commented Nov 10, 2022

Code Climate has analyzed commit 532c31c and detected 0 issues on this pull request.

View more on Code Climate.

@sergioifg94 sergioifg94 changed the title [WIP] THREESCALE-8749: Ability to set APICAST_SERVICE_CACHE_SIZE THREESCALE-8749: Ability to set APICAST_SERVICE_CACHE_SIZE Nov 10, 2022
@sergioifg94 sergioifg94 requested a review from eguzki November 10, 2022 16:02
@sergioifg94 sergioifg94 merged commit 4cf6ab1 into 3scale:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants