-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus: Add a metric when a worker starts. #1228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new worker starts,a new counter will be increased. This metric will help to identify when an external process kills any worker process because of any reason. Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
Worker_metric
branch
from
September 17, 2020 20:14
e2256b4
to
67f1a39
Compare
davidor
reviewed
Sep 17, 2020
@@ -54,6 +54,9 @@ openresty_shdict_free_space{dict="limiter"} 1032192 | |||
openresty_shdict_free_space{dict="locks"} 1032192 | |||
openresty_shdict_free_space{dict="prometheus_metrics"} 16662528 | |||
openresty_shdict_free_space{dict="rate_limit_headers"} 20840448 | |||
# HELP worker_process Number of times that a nginx worker has been started | |||
# TYPE worker_process counter | |||
worker_process{} 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the {}
mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's needed.
davidor
approved these changes
Sep 18, 2020
porueesq
reviewed
Sep 18, 2020
Co-authored-by: porueesq <43811485+porueesq@users.noreply.github.com>
porueesq
approved these changes
Sep 18, 2020
eloycoto
added a commit
to eloycoto/3scale-Operations
that referenced
this pull request
Oct 8, 2020
This is the SOP for worker restart limit. Related to: 3scale/3scale-operator#484 3scale/APIcast#1228 https://issues.redhat.com/browse/THREESCALE-5965 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
added a commit
to eloycoto/3scale-Operations
that referenced
this pull request
Oct 8, 2020
This is the SOP for worker restart limit. Related to: 3scale/3scale-operator#484 3scale/APIcast#1228 https://issues.redhat.com/browse/THREESCALE-5965 Fix THREESCALE-6119 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
added a commit
to eloycoto/3scale-Operations
that referenced
this pull request
Oct 14, 2020
This is the SOP for worker restart limit. Related to: 3scale/3scale-operator#484 3scale/APIcast#1228 https://issues.redhat.com/browse/THREESCALE-5965 Fix THREESCALE-6119 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
added a commit
to 3scale/3scale-Operations
that referenced
this pull request
Oct 14, 2020
This is the SOP for worker restart limit. Related to: 3scale/3scale-operator#484 3scale/APIcast#1228 https://issues.redhat.com/browse/THREESCALE-5965 Fix THREESCALE-6119 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new worker starts,a new counter will be increased. This metric
will help to identify when an external process kills any worker process
because of any reason.
Signed-off-by: Eloy Coto eloy.coto@acalustra.com