Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APICAST_ACCESS_LOG_BUFFER option #1248

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Conversation

eloycoto
Copy link
Contributor

@eloycoto eloycoto commented Jan 8, 2021

This commit add a new way to write access log, based on chunks, so
access log writes only happens when a buffer is full and this improves the
performance by reducing the number of system calls.

Signed-off-by: Eloy Coto eloy.coto@acalustra.com

@eloycoto eloycoto requested review from a team as code owners January 8, 2021 17:41
Copy link
Contributor

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you have any numbers? Just to get an idea about the perf gains that a log buffer of 1K or 4K for example gives.

doc/parameters.md Outdated Show resolved Hide resolved
doc/parameters.md Outdated Show resolved Hide resolved
Copy link
Contributor

@porueesq porueesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@eloycoto eloycoto force-pushed the access_logs branch 2 times, most recently from b225e76 to 6326c2c Compare January 11, 2021 16:02
eloycoto and others added 2 commits January 12, 2021 16:14
This commit add a new way to write access log, based on chunks, so
access log writes only happens when a buffer is full and this improves the
performance by reducing the number of system calls.

Fix THREESCALE-6563

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Co-authored-by: porueesq <43811485+porueesq@users.noreply.github.com>
@eloycoto eloycoto merged commit 5744e35 into 3scale:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants