Performance improvements #1250
Merged
Performance improvements #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Jan 12, 2021
| @@ -34,6 +34,7 @@ events { | |||
|
|
|||
| http { | |||
| sendfile on; | |||
| sendfile_max_chunk 512k; | |||
There was a problem hiding this comment.
I've read the description in https://nginx.org/en/docs/http/ngx_http_core_module.html#sendfile_max_chunk but it's not clear to me in which cases this could be worse than the default. What scenario did you test and what perf numbers did you get?
There was a problem hiding this comment.
Mainly, when large bodies are send. We have an Hyperfoil testcase where a lot of large bodies are in place. With this change, we got around 5% more rps.
There was a problem hiding this comment.
👍
Do you know if there's a performance penalty for use cases with small or no request bodies?
There was a problem hiding this comment.
no penalty, because is write in chunks instead of fill the chunk, so not issues at all.
davidor
approved these changes
Jan 12, 2021
When a large body is send over APICast, the sendfile is unlimited, so a single connection can seize the whole worker process and things can be in a very bad situation. This commit set the limit by chunks Doc: http://nginx.org/en/docs/http/ngx_http_core_module.html#sendfile_max_chunk Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Because a lot of users are using Openid connect, the token is stored in this shared memory, so it get full quite fast. With this change, the value is a bit bigger, and authrep calls will be executed out of band, instead of request time. Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: https://issues.redhat.com/browse/THREESCALE-6570