CORS: Enable multiple Origins value based on regexp. #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianpm
reviewed
Jan 14, 2021
damianpm
reviewed
Jan 19, 2021
| @@ -46,7 +46,7 @@ | |||
| } | |||
| }, | |||
| "allow_origin": { | |||
| "description": "Origin allowed for CORS requests. The field expects only one origin (e.g. https://example.com) or '*'. If left blank, the value of the 'Origin' request header will be used. In case of valid regexp, and if it matches with Origin header value, the value will be set to the Origin Value. In case of does not match, the header will not set at all.", | |||
| "description": "Origin allowed for CORS requests. The field expects only one origin (e.g. <code>https://example.com</code>) or '*'. If left blank, the value of the 'Origin' request header will be used. <br> In order to allow more than one origin it is possible to use a regular expression, if it matches with Origin header value, the value will be set to the Origin Value. In case it does not match, the header will not set at all. Example: <code>(api|web).test.com</code> wil match both <code>api.test.com</code> and <code>web.test.com</code>", | |||
There was a problem hiding this comment.
It seems like GH picked the first suggestion instead of the second (corrected without html markup) :(
There was a problem hiding this comment.
Fixed now! Thanks!
eloycoto
force-pushed
the
CORS_changes
branch
2 times, most recently
from
02d21ff
to
ba678fa
Compare
This will check if the allow_origins is a valid regexp, and if it is, will match with the Origin header value, it'll set the Access-Control-Allow-Origin header to the Origin value. Examples: ``` Config | Origin Request Header Value | Access-Control-Allow-Origin header (api|web).test.com | http://web.test.com | http://web.test.com (api|web).test.com | http://api.test.com | http://api.test.com (api|web).test.com | http://staging.test.com | Not header set http://test.com | http://api.test.com | http://test.com * | http://api.test.com | * blank | http://api.test.com | http://api.test.com ``` Fix: THREESCALE-6569 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
CORS_changes
branch
from
ba678fa
to
e2b0942
Compare
davidor
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check if the allow_origins is a valid regexp, and if it is,
will match with the Origin header value, it'll set the
Access-Control-Allow-Origin header to the Origin value.
Examples:
Fix: THREESCALE-6569
Signed-off-by: Eloy Coto eloy.coto@acalustra.com