adds method matching check to rewrite url captures policy #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevprice83
changed the title
kevprice83
changed the title
eloycoto
reviewed
Jan 20, 2021
| -- Returns true if no Method is provided in the config for backwardscompatibility | ||
| local function is_match_methods(methods) | ||
|
|
||
| local request_method = ngx.req.get_method() |
There was a problem hiding this comment.
I would move this line after the condition, but it's ok if you want to keep it.
There was a problem hiding this comment.
ah yes makes sense, not using it in the conditional statement anyway, thanks
eloycoto
suggested changes
Jan 20, 2021
| @@ -233,3 +233,51 @@ yay, api backend | |||
| --- error_code: 200 | |||
| --- no_error_log | |||
| [error] | |||
|
|
|||
| === TEST 5: one transformation with method that doesn't match | |||
There was a problem hiding this comment.
We should add two test that match at least one method:
Test6: One single method works.
Test7: Array with methods [POST, UPDATE, GET] will match if GET method is in there. (Want to check the next method of the array is working)
eloycoto
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of methods to the transformation. Checks the request method against the method configured in the policy just as it is done in the URL rewrite policy.
Fixes: THREESCALE-6270