Caching: Fix race #1259
Merged
Caching: Fix race #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
THREESCALE-4464b
branch
2 times, most recently
from
1292bbf
to
79f07b6
Compare
davidor
reviewed
Mar 22, 2021
| @@ -101,17 +101,29 @@ local function handler(config) | |||
| return res | |||
| end | |||
|
|
|||
| local function is_disabled(config) | |||
| if config.caching_type and config.caching_type == "none" then | |||
There was a problem hiding this comment.
This can be simplified:
return config.caching_type and config.caching_type == "none"
eloycoto
force-pushed
the
THREESCALE-4464b
branch
2 times, most recently
from
20a6a46
to
b7ee759
Compare
When caching is disabled with none, the cache key can be in there, and a
race condition can be happend with this.
To test this:
1) Strict caching mode
2) Made a request, 200 OK cache.set("$KEY", 200)
3) Update config to none
4) apicast/proxy:authorize -> cache.get($KEY) is 200
5) request go to the API
6) Authrep, cache for $KEY is deleted.
Next request will return 403.
Fixed behaviour:
1) Strict caching mode
2) Made a request, 200 OK cache.set("$KEY", 200)
3) Update config to none
4) apicast/proxy:authorize -> cache.get($KEY) is 200
5) cache_is_disabled = true -> execute backend call.
5) request go to the API, and fails
6) Authrep, cache for $KEY is deleted.
Fix THREESCALE-4464
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
THREESCALE-4464b
branch
from
b7ee759
to
85c0f78
Compare
unleashed
approved these changes
Aug 17, 2021
YUP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caching is disabled with none, the cache key can be in there, and a
race condition can be happend with this.
To test this:
Next request will return 403.
Fixed behaviour:
Fix THREESCALE-4464
Signed-off-by: Eloy Coto eloy.coto@acalustra.com