http-ng: fix HOST header #1264
Merged
http-ng: fix HOST header #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This strips the default port and use the correct host header value when using http-ng ``` URL Host Header -------------------------------------------------------------- http://foo.com foo.com http://foo.com:80 foo.com http://foo.com:80/test foo.com http://foo.com:8080/test foo.com:8080 https://foo.com/ foo.com https://foo.com:8043/ foo.com:8043 https://foo.com:8043/test foo.com:8043 ``` Fix THREESCALE-2235 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
THREESCALE-2235
branch
from
b44873d
to
afa47b0
Compare
davidor
reviewed
Mar 22, 2021
|
|
||
| if len then len = len - 1 end | ||
| if port and port ~= default_port then |
There was a problem hiding this comment.
I've seen in the JIRA issue that this strips the port only if it's the default one to fix some issue when using OIDC. However, this is a generic client, doesn't it affect other use cases?
There was a problem hiding this comment.
No, not a issue at all.
davidor
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strips the default port and use the correct host header value when
using http-ng
Fix THREESCALE-2235
Signed-off-by: Eloy Coto eloy.coto@acalustra.com