OIDC: Fix discovery content-type issues #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
approved these changes
Apr 20, 2021
eloycoto
force-pushed
the
THREESCALE-6913
branch
from
0d4d8e1
to
283621f
Compare
When JWK response was not application/json content_type, the keys cannot be parsed and OIDC flow failed. With this fix, if the application is returning `jwk-set+json`, something valid that was not parsed as we should.[0] [0] https://tools.ietf.org/html/rfc7517#section-8.5.1 Fix: THREESCALE-6913 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
THREESCALE-6913
branch
from
283621f
to
d475978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JWK response was not application/json content_type, the keys cannot
be parsed and OIDC flow failed.
With this fix, if the application is returning
jwk-set+json, somethingvalid that was not parsed as we should.[0]
[0] https://tools.ietf.org/html/rfc7517#section-8.5.1
Fix: THREESCALE-6913
Signed-off-by: Eloy Coto eloy.coto@acalustra.com