Usage: fix issues on encoding #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
rate-limit-issue
branch
5 times, most recently
from
14ea4f3
to
f7b11d4
Compare
eloycoto
changed the title
eloycoto
force-pushed
the
rate-limit-issue
branch
from
f7b11d4
to
177616a
Compare
davidor
reviewed
May 31, 2021
spec/usage_spec.lua
Outdated
|
|
||
| it("with multiple metrics return the same", function() | ||
| local usage = Usage.new() | ||
| usage:add('a', 0) |
There was a problem hiding this comment.
It'd be better to give different values to the metrics to test that they are assigned properly in the resulting string.
| assert.are.same(usage:encoded_format(), "usage%5Ba%5D=0&usage%5Bb%5D=0&usage%5Bc%5D=0") | ||
| end) | ||
|
|
||
| it("integer metrics", function() |
There was a problem hiding this comment.
Do we need to test this? I don't think this is supported 🤔
There was a problem hiding this comment.
I was thinking the same, but didn't harm to have just in case.
eloycoto
force-pushed
the
rate-limit-issue
branch
2 times, most recently
from
03f7f39
to
c8b9a18
Compare
davidor
reviewed
May 31, 2021
| usage:add('a', 0) | ||
| usage:add('c', 3) | ||
| usage:add('b', 2) | ||
| assert.are.same(usage:encoded_format(), "usage%5Ba%5D=1&usage%5Bb%5D=2&usage%5Bc%5D=3") |
There was a problem hiding this comment.
Tests are failing because of this. It expects a = 1, but above it's set to 0.
Usage keys are based on ngx.encode_args, BUT due to the Luajit update
the data is not always the same, so the following usage metatable:
```
{
metric_a=1,
metric_b=1,
}
```
can be `metric_a=1&metric_b=1` or `metric_b=1&metric_a=1`, so the cached
key is not the same, and auth call will happen a few more times when it
shouldn't.
The way that I followed is the same as Openresty, and the escape_uri
should always be a string due to the usage method.
Fix THREESCALE-7122
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
rate-limit-issue
branch
from
c8b9a18
to
adc4018
Compare
davidor
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage keys are based on ngx.encode_args, BUT due to the Luajit update
the data is not always the same, so the following usage metatable:
can be
metric_a=1&metric_b=1ormetric_b=1&metric_a=1, so the cachedkey is not the same, and auth call will happen a few more times when it
shouldn't.
The way that I followed is the same as Openresty, and the escape_uri
should always be a string due to the usage method.
Fix THREESCALE-7122